Skip to content

rbac: Add networkpolicies - #341

Merged
Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:net-rbac-main
Aug 19, 2026
Merged

rbac: Add networkpolicies#341
Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:net-rbac-main

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Aug 18, 2026 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Member

as required by OLM, see e.g. confidential-clusters/operator#161:

"msg": "Operator \"confidential-cluster-operator\" version \"0.2.1\" is missing required NetworkPolicy RBAC (networking.k8s.io/networkpolicies with create, delete, and update/patch)",
"metadata": {
  "code": "olm.required_network_policy_rbac_for_operands",
  "collections": [
    "redhat"
  ],
  "description": "Operators are required to manage the network policies of their operands. This rule verifies that operator bundles request sufficient RBAC permissions to manage NetworkPolicy lifecycle (create, delete, and update/patch) for networking.k8s.io/networkpolicies in their ClusterServiceVersion. Bundles whose operator name and major.minor version are listed in the `operator_network_policy_rbac_exceptions` rule data key are exempt from this requirement. To exclude this rule add \"olm.required_network_policy_rbac_for_operands\" to the `exclude` section of the policy configuration.",
  "effective_on": "2026-08-07T00:00:00Z",
  "solution": "Add a rule granting create, delete, and update/patch on networking.k8s.io/networkpolicies to the ClusterServiceVersion clusterPermissions or permissions, or add the operator name and its major.minor version to the operator_network_policy_rbac_exceptions rule data key.",
  "title": "NetworkPolicy RBAC present in OLM bundle"
}

Forward-port of #339. Tested on confidential-clusters/operator#163.

Summary by Sourcery

Enhancements:

  • Grant the operator RBAC permissions to create, delete, patch, and update Kubernetes NetworkPolicy resources.

@Jakob-Naucke
rbac: Add networkpolicies
17a9892 
as required by OLM, see
e.g. confidential-clusters/operator#161

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds required RBAC for managing Kubernetes NetworkPolicy resources via kubebuilder annotations, ensuring the operator bundle satisfies OLM’s network policy RBAC requirement.

File-Level Changes

Change Details Files
Grant the operator RBAC permissions to manage NetworkPolicy resources.
  • Add kubebuilder RBAC annotation for networking.k8s.io networkpolicies with create, delete, patch, and update verbs so controller-gen will include these in the generated ClusterRole/ClusterServiceVersion
 api/v1alpha1/crds.go
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Aug 18, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether the operator needs read access (get/list/watch) to NetworkPolicy resources as well as write access, for consistency with other RBAC entries and to avoid reconcile failures when inspecting existing policies.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Consider whether the operator needs read access (get/list/watch) to NetworkPolicy resources as well as write access, for consistency with other RBAC entries and to avoid reconcile failures when inspecting existing policies.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@uril

uril commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Sourcery-ai commented: "Consider whether the operator needs ... access to NetworkPolicy"

I do not know if we need it or not.
git grep -i NetworkPolicy # shows nothing.

It may be desired in the future to limit access to the services (limit write access to Trustee) and setup a restrictive policy.

uril
uril approved these changes Aug 18, 2026
View reviewed changes

@uril uril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a comment above

@openshift-ci openshift-ci Bot added the lgtm label Aug 18, 2026
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke, uril

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jakob-Naucke
Jakob-Naucke merged commit cfeb21a into trusted-execution-clusters:main Aug 19, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@uril uril uril approved these changes
@alicefr alicefr Awaiting requested review from alicefr
@SpaceFace02 SpaceFace02 Awaiting requested review from SpaceFace02

Assignees

@uril uril

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jakob-Naucke @uril